Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trying to pick up item too small for the pockets fails silently. #54725

Closed
moxian opened this issue Jan 24, 2022 · 5 comments
Closed

Trying to pick up item too small for the pockets fails silently. #54725

moxian opened this issue Jan 24, 2022 · 5 comments
Labels
Items: Containers Things that hold other things (S2 - Confirmed) Bug that's been confirmed to exist

Comments

@moxian
Copy link
Contributor

moxian commented Jan 24, 2022

Describe the bug

There are some wool socks next to me that i can't pick up despite having a half-empty duffel bag on me, and more than enough spare carry capacity.

Steps to reproduce

  • Load the save
    Port Mayaca-no-socks.zip
  • g -> <Right arrow> -> <Enter> to pick up the socks
  • Observe that no messages are produced, and the socks have their location unchanged.

Expected behavior

Socks get picked up.

Screenshots

The socks can quite clearly fit into my bags:
20220124-031704-cataclysm-tiles
20220124-031724-cataclysm-tiles

Versions and configuration

  • OS: Windows
    • OS Version: 10.0 2009
  • Game Version: 5ac1a12 [64-bit]
  • Graphics Version: Tiles
  • Game Language: System language []
  • Mods loaded: [
    Dark Days Ahead [dda],
    Disable NPC Needs [no_npc_food],
    No Fungal Growth [no_fungal_growth],
    Bionic Professions [package_bionic_professions]
    ]

Additional context

No response
@moxian
Copy link
Contributor Author

moxian commented Jan 24, 2022

Ah, wait, i see now, the "spare" capacity is only in the pockets that have min volume restrictions (e.g.
20220124-032535)

, and socks are too small to fit there. So the behavior is expected, and the only problem is the lack of error messages describing the issue.

@moxian moxian changed the title Can't pick up item for no apparent reason. Trying to pick up item too small for the pockets fails silently. Jan 24, 2022
@moxian
Copy link
Contributor Author

moxian commented Jan 24, 2022

Oh, and this is a duplicate of #54703 ..

@moxian moxian closed this as completed Jan 24, 2022
@LeahLuong
Copy link

LeahLuong commented Jan 24, 2022 •
edited

Not sure this is a dupe because they are getting an error message in the other thread & it's unknown what sort of carrying capacity they have.

Not sure you should close this issue because the player prob should get a message when failing to pick up.

@moxian moxian reopened this Jan 25, 2022
@matshou
Copy link
Contributor

matshou commented Jan 25, 2022

After investigating the situation it seems there is an additional bug revealed here.

Unless this is intended behavior the pair of socks you are trying to pick up should automatically go into the plastic jerrycan.
That item has no pocket restrictions and in fact does allow the socks to go inside it's main pocket both by manually placing them inside as well as automatically when being wielded. For some reason this doesn't happen when the item is in the backpack.

@matshou
Copy link
Contributor

matshou commented Jan 25, 2022

The bug mentioned above has been reported in #53807

@Maleclypse Maleclypse added (S2 - Confirmed) Bug that's been confirmed to exist 0.G suggested release blocker Items: Containers Things that hold other things labels Jan 26, 2022
robkuijper added a commit to robkuijper/Cataclysm-DDA that referenced this issue Jan 30, 2022
@robkuijper
Fix nested pockets pickup
bb0212a 
There are quite some discrepancies between can_contain and
best_pocket functionality. This commit looks to fix that and actually
allow nested pockets to work properly as long as there is space.
fixes CleverRaven#54725
@robkuijper robkuijper mentioned this issue Jan 30, 2022
Merged
robkuijper added a commit to robkuijper/Cataclysm-DDA that referenced this issue Feb 4, 2022
@robkuijper
Fix nested pockets pickup
39feb6e 
There are quite some discrepancies between can_contain and
best_pocket functionality. This commit looks to fix that and actually
allow nested pockets to work properly as long as there is space.
fixes CleverRaven#54725
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Items: Containers Things that hold other things (S2 - Confirmed) Bug that's been confirmed to exist
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@moxian @matshou @Maleclypse @LeahLuong